-
-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: git workflow update macos to macos-latest no other changes #1082
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey @dave42w 👋 Could you have a look at this? The CI is failing. :// I have suppressed clippy for a while. |
So it looks like we are missing something that should be build by rust. I wonder if this is an interconnected thing. Codspeed is failing in this CI because we have not upgraded it to v3 at this point. In codspeed.yml we build for darwin:
If codspeed is failing then are we adding the darwin target to the maturin build? Otherwise I have no idea why simply changing the macos version would cause this problem. Anyway this is the specific error.
|
CodSpeed Performance ReportMerging #1082 will not alter performanceComparing Summary
|
@dave42w , I am not certain. But I'll give it a shot today. |
closing this now. |
Description
This PR updates the github workflow from macos-12 (deprecated) to macos-latest
Only affects preview-deployments.yml and release-CI.yml
Summary
This PR does....
PR Checklist
Please ensure that:
Pre-Commit Instructions: